Enable static network configuration via vmware guestinfo #2 #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o newline at end of file
|
Also submitted patch to opendev: https://review.opendev.org/c/x/cloudbase-init/+/829757/comments/2f77aa55_db8f1d1e |
|
Is there anything needed to push this past the finish line? |
|
Could someone merge if this PR is ok ? |
|
@pbesret I gave it a recheck on the opendev board, as we merged support for the 3.11 Python. Let's continue this discussion on opendev. Thanks! |
|
Hi folks. |
|
Hi @ader1990. This feature will be awesome! Can we expect a merge soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on pull request #83 opened on Nov 22, 2021 by kimbernator.
Apply fixes for "pep8: H306: imports not in alphabetical order" and "pep8: W292 no newline at end of file", which hopefully should make this mergeable.