Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable static network configuration via vmware guestinfo #83

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kimbernator
Copy link

Resolves #78

This enables static networking configuration in the vmware guestinfo metadata source. I basically just have it parse the network data using the nocloud network config v1 parser since they follow the same spec.

I'm a bit green to this codebase so please let me know if there's more I need to add for this to have the intended effect.

@doumhfr
Copy link

doumhfr commented Feb 7, 2022

is this patch working ?

I try to do the modification but I've got an error :
Cannot import name 'NoCloudNetworkConfigV1Parser'

@ader1990
Copy link
Member

ader1990 commented Feb 8, 2022

is this patch working ?

I try to do the modification but I've got an error : Cannot import name 'NoCloudNetworkConfigV1Parser'

Hello,

Please make sure that you have the latest cloudbase-init version installed / cloned before trying to
patch the code with this commit.

We are currently using OpenStack's review workflow for accepting patches, see this workflow: #62 (comment)

Thank you,
Adrian

@twalcari
Copy link

twalcari commented Feb 8, 2022

Hi Adrian,

Thank you for commenting on this issue. Would it be possible to add the information about this OpenStack review workflow that you have adopted somewhere visible in this repository? ie. in the README or by mentioning it in the pull request template ? I would already have followed all steps in this workflow months ago if I had known about it.

@kimbernator
Copy link
Author

The import should be fixed now. The codebase is on the current version.

@kimbernator
Copy link
Author

I have submitted the patch as requested. As @twalcari said, this should be documented. Frustrating that it took two and a half months to be notified of this.

@jaymzmac
Copy link

jaymzmac commented Jun 7, 2022

@kimbernator did you see there were some minor lint issues that need fixing before your patch can be merged? https://review.opendev.org/c/x/cloudbase-init/+/829757

@PrimordialLight
Copy link

@kimbernator you able to clean up those two small lint issues? Been wanting to use this patch for awhile

@kimbernator
Copy link
Author

I no longer work for the employer whose email I used to log into opendev.org, and consequently I don't have a personal or professional need for this change. If someone else wants to make this contribution, they are free to do so.

@FlorianLaunay
Copy link
Contributor

Feature will now be provided by #107 . Could you please close this one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VMwareGuestInfoService is not implementing static network configuration
7 participants