fix: normalize repo language in list_repos_using_installation #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #15 +/- ##
==========================================
- Coverage 91.28% 91.27% -0.02%
==========================================
Files 90 90
Lines 8076 8077 +1
Branches 1228 1228
==========================================
Hits 7372 7372
- Misses 701 702 +1
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
scott-codecov
approved these changes
Jul 28, 2023
matt-codecov
force-pushed
the
matt/normalize-language-oops
branch
from
690d1cb
to
d634624
Compare
|
this force-push rebased the change on top of the commit hash that is currently deployed in worker. grabbing the hash, rebasing back to main, and merging. that way we can deploy without deploying other changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list_repos_using_installation()was changed to return full repo dicts rather than justservice_id. the format of the return was not made to match that oflist_repos()and didn't include some of the same normalization which caused errorsthis PR is a quick fix
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.