Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change: add Faker.Fiction namespace #207

Closed
wants to merge 1 commit into from
Closed

Breaking Change: add Faker.Fiction namespace #207

wants to merge 1 commit into from

Conversation

igas
Copy link
Member

@igas igas commented Oct 4, 2018

No description provided.

@igas igas added this to the 0.12.0 milestone Oct 4, 2018
@igas
Copy link
Member Author

igas commented Oct 4, 2018

@vbrazo please take a look, what do you think?

@vbrazo
Copy link
Member

vbrazo commented Oct 5, 2018

@igas I think it's a great time to introduce this kind of namespaces since the library is still young. Defining good taxonomy will be challenging and we're here to suggest names if needed.

Would we need to deprecate these old modules?

@igas
Copy link
Member Author

igas commented Oct 5, 2018

@vbrazo agreed, I looked at different faker libs and what they suggested and so far this one I'm comfortable with, there are others I saw like Books, TvShows, Movies, PopCulture etc, but I think they are often mixed like Books/TvShows, so I guess Fiction would be a good one.

Regarding deprecations, this is the good question, we are pre 1.0, which means API is not stable, but I guess we still can make it right for our users. Wanna get on top of it?

@vbrazo
Copy link
Member

vbrazo commented Oct 5, 2018

sure, why not? We can add the namespaces together.

Let me open a new issue to centralize the discussions there.

@vbrazo
Copy link
Member

vbrazo commented Oct 5, 2018

Issue created: #208.

@vbrazo vbrazo modified the milestones: 0.12.0, 0.13.0 Feb 11, 2019
@igas igas mentioned this pull request Aug 4, 2019
2 tasks
@anthonator
Copy link
Collaborator

This is stale so going to close.

@anthonator anthonator closed this Aug 7, 2020
@igas igas deleted the fiction branch October 4, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants