Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #15

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Update dependencies #15

merged 3 commits into from
Jan 22, 2024

Conversation

rnestler
Copy link
Member

@rnestler rnestler commented Jan 22, 2024

This fixes a few of the warnings which are printed when running the specs:

/home/raphael/.asdf/installs/ruby/3.1.2/bin/bundle: warning: Exception in finalizer #<Proc:0x00007f1717eea360 /home/raphael/.asdf/installs/ruby/3.1.2/lib/ruby/gems/3.1.0/gems/vcr-6.0.0/lib/vcr/library_hooks/webmock.rb:36 (lambda)>
/home/raphael/.asdf/installs/ruby/3.1.2/lib/ruby/gems/3.1.0/gems/vcr-6.0.0/lib/vcr/library_hooks/webmock.rb:36:in `block in global_hook_disabled_requests': wrong number of arguments (given 1, expected 0) (ArgumentError)

We don't test with older Ruby versions, so don't know if the code works
with them.
@rnestler rnestler requested a review from a team January 22, 2024 11:19
@rnestler rnestler self-assigned this Jan 22, 2024
@rnestler rnestler mentioned this pull request Jan 22, 2024
Copy link
Member

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit!

@rnestler rnestler merged commit 6349aea into master Jan 22, 2024
2 checks passed
@rnestler rnestler deleted the update-dependencies branch January 22, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants