Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass billing details in ElementsSessionContext #9446

Draft
wants to merge 1 commit into
base: tillh/link-card-brand-and-billing-details
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Oct 15, 2024

Summary

This pull request adds the billing address to the ElementsSessionContext, allowing us to pass it along when creating the PaymentMethod in either the web or native view.

Motivation

BANKCON-15709

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Oct 15, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │          uncompressed          
          ├───────────┬───────────┬──────────┼──────────┬──────────┬──────────
 APK      │ old       │ new       │ diff     │ old      │ new      │ diff     
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
      dex │     4 MiB │     4 MiB │ +1.2 KiB │  8.6 MiB │  8.6 MiB │ +4.1 KiB 
     arsc │   2.3 MiB │   2.3 MiB │      0 B │  2.3 MiB │  2.3 MiB │      0 B 
 manifest │   5.1 KiB │   5.1 KiB │      0 B │ 25.6 KiB │ 25.6 KiB │      0 B 
      res │ 933.8 KiB │ 933.8 KiB │      0 B │  1.5 MiB │  1.5 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │    6 MiB │    6 MiB │      0 B 
    asset │   2.9 MiB │   2.9 MiB │     -3 B │  2.9 MiB │  2.9 MiB │     -3 B 
    other │ 200.4 KiB │ 200.4 KiB │    -21 B │  442 KiB │  442 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
    total │  12.9 MiB │  12.9 MiB │ +1.2 KiB │ 21.8 MiB │ 21.8 MiB │ +4.1 KiB 

 DEX     │ old   │ new   │ diff            
─────────┼───────┼───────┼─────────────────
   files │     1 │     1 │   0             
 strings │ 42449 │ 42470 │ +21 (+60 -39)   
   types │ 14249 │ 14254 │  +5 (+38 -33)   
 classes │ 11861 │ 11864 │  +3 (+6 -3)     
 methods │ 60977 │ 60995 │ +18 (+804 -786) 
  fields │ 40208 │ 40225 │ +17 (+783 -766) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6269 │ 6269 │  0
APK
     compressed      │     uncompressed     │                                           
──────────┬──────────┼───────────┬──────────┤                                           
 size     │ diff     │ size      │ diff     │ path                                      
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
    4 MiB │ +1.2 KiB │   8.6 MiB │ +4.1 KiB │ ∆ classes.dex                             
 53.5 KiB │    -16 B │ 118.5 KiB │      0 B │ ∆ META-INF/CERT.SF                        
 50.3 KiB │     -3 B │ 118.4 KiB │      0 B │ ∆ META-INF/MANIFEST.MF                    
    8 KiB │     -2 B │   7.9 KiB │     -2 B │ ∆ assets/dexopt/baseline.prof             
    271 B │     -1 B │     120 B │      0 B │ ∆ META-INF/version-control-info.textproto 
    1 KiB │     -1 B │     899 B │     -1 B │ ∆ assets/dexopt/baseline.profm            
  1.2 KiB │     -1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  4.1 MiB │ +1.2 KiB │   8.9 MiB │ +4.1 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   42449 │ 42470 │ +21 (+60 -39) 
  
  + , billingAddress=
  + , billingEmailAddress=
  + , city=
  + , showAddressFields=
  + , showEmailField=
  + , showPhoneField=
  + Address(line1=
  + BankFormFieldsState(showNameField=
  + BillingAddress(name=
  + Consumer session email address cannot be null
  + LH5/K;
  + LH5/L;
  + LR7/L;
  + LS3/c;
  + Lh7/r;
  + Lx7/V;
  + VILLLLLLLLZZ
  + VLLLZZZLLLLLLLLII
  + VLLLZZZLLLLLLLLLII
  + VLZZLLLLLLI
  + VZZLLLLLLLI
  + [LH5/g;
  + [LH5/i;
  + [LH5/p;
  + [LH5/t;
  + [LH5/w;
  + [LR7/B;
  + [LR7/y;
  + [LS3/b;
  + [LT7/h;
  + [LY7/A;
  + [LY7/d;
  + [LZ6/I;
  + [LZ6/J0;
  + [LZ6/L0;
  + [LZ6/T2;
  + [LZ6/i2;
  + [LZ6/x1;
  + [Lcom/stripe/android/stripecardscan/scanui/d;
  + [Lh7/q;
  + [Lh8/a;
  + [Lh8/f;
  + [Lh8/m;
  + [Lh8/o;
  + [Lk3/D;
  + [Lm6/L2;
  + [Lm6/O2;
  + [Lm6/Y;
  + [Lm6/b0;
  + [Ln8/f;
  + [Lr8/F;
  + [Lx7/T;
  + [Ly3/d;
  + administrative_area
  + billingEmailAddress
  + billing_phone
  + fieldsState
  + line_1
  + line_2
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"e37d71e","r8-mode":"full","version":"8.5.35"}
  
  - LT7/y;
  - Lh8/q;
  - Ly3/k;
  - VILLLLLLLLZZZ
  - VLLLZZZZLLLLLLLLII
  - VLLLZZZZLLLLLLLLLII
  - VLZZZLLLLLLI
  - VZLZZLLLLLLI
  - [LH5/m;
  - [LH5/n;
  - [LH5/r;
  - [LR7/u;
  - [LR7/z;
  - [LS3/a;
  - [LT7/k;
  - [LY7/b;
  - [LY7/y;
  - [LZ6/E;
  - [LZ6/G0;
  - [LZ6/K0;
  - [LZ6/R2;
  - [LZ6/g2;
  - [LZ6/v1;
  - [Lcom/stripe/android/stripecardscan/scanui/b;
  - [Lh7/o;
  - [Lh8/b;
  - [Lh8/h;
  - [Lh8/n;
  - [Lh8/q;
  - [Lk3/C;
  - [Lm6/K2;
  - [Lm6/N2;
  - [Lm6/X;
  - [Lm6/a0;
  - [Ln8/d;
  - [Lr8/D;
  - [Lx7/S;
  - [Ly3/g;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"c56b1dd","r8-mode":"full","version":"8.5.35"}
  

TYPES:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   14249 │ 14254 │ +5 (+38 -33) 
  
  + LH5/K;
  + LH5/L;
  + LR7/L;
  + LS3/c;
  + Lh7/r;
  + Lx7/V;
  + [LH5/g;
  + [LH5/i;
  + [LH5/p;
  + [LH5/t;
  + [LH5/w;
  + [LR7/B;
  + [LR7/y;
  + [LS3/b;
  + [LT7/h;
  + [LY7/A;
  + [LY7/d;
  + [LZ6/I;
  + [LZ6/J0;
  + [LZ6/L0;
  + [LZ6/T2;
  + [LZ6/i2;
  + [LZ6/x1;
  + [Lcom/stripe/android/stripecardscan/scanui/d;
  + [Lh7/q;
  + [Lh8/a;
  + [Lh8/f;
  + [Lh8/m;
  + [Lh8/o;
  + [Lk3/D;
  + [Lm6/L2;
  + [Lm6/O2;
  + [Lm6/Y;
  + [Lm6/b0;
  + [Ln8/f;
  + [Lr8/F;
  + [Lx7/T;
  + [Ly3/d;
  
  - LT7/y;
  - Lh8/q;
  - Ly3/k;
  - [LH5/m;
  - [LH5/n;
  - [LH5/r;
  - [LR7/u;
  - [LR7/z;
  - [LS3/a;
  - [LT7/k;
  - [LY7/b;
  - [LY7/y;
  - [LZ6/E;
  - [LZ6/G0;
  - [LZ6/K0;
  - [LZ6/R2;
  - [LZ6/g2;
  - [LZ6/v1;
  - [Lcom/stripe/android/stripecardscan/scanui/b;
  - [Lh7/o;
  - [Lh8/b;
  - [Lh8/h;
  - [Lh8/n;
  - [Lh8/q;
  - [Lk3/C;
  - [Lm6/K2;
  - [Lm6/N2;
  - [Lm6/X;
  - [Lm6/a0;
  - [Ln8/d;
  - [Lr8/D;
  - [Lx7/S;
  - [Ly3/g;
  

METHODS:

   old   │ new   │ diff            
  ───────┼───────┼─────────────────
   60977 │ 60995 │ +18 (+804 -786) 
  
  + A4.d i() → a
  + A7.A e(Object, G1, T, p0)
  + A7.B e(Object, G1, T, p0)
  + A7.D e(Object, G1, T, p0)
  + A7.F e(Object, G1, T, p0)
  + A7.K e(Object, G1, T, p0)
  + A7.L e(Object, G1, T, p0)
  + A7.Q e(Object, G1, T, p0)
  + A7.T e(Object, G1, T, p0)
  + A7.T o(boolean, G1, T, p0)
  + A7.V e(Object, G1, T, p0)
  + A7.Y e(Object, G1, T, p0)
  + A7.Y o(boolean, G1, T, p0)
  + A7.a0 e(Object, G1, T, p0)
  + A7.a e(Object, G1, T, p0)
  + A7.a o(boolean, G1, T, p0)
  + A7.b e(Object, G1, T, p0)
  + A7.c0 e(Object, G1, T, p0)
  + A7.d e(Object, G1, T, p0)
  + A7.d o(boolean, G1, T, p0)
  + A7.f e(Object, G1, T, p0)
  + A7.f o(boolean, G1, T, p0)
  + A7.g e(Object, G1, T, p0)
  + A7.l a(T) → Z1
  + A7.m a(T) → Z1
  + A7.n a(T) → Z1
  + A7.o a(T) → Z1
  + A7.p e(Object, G1, T, p0)
  + A7.r0 e(Object, G1, T, p0)
  + A7.r e(Object, G1, T, p0)
  + A7.t e(Object, G1, T, p0)
  + A7.u e(Object, G1, T, p0)
  + A7.v e(Object, G1, T, p0)
  + A7.y e(Object, G1, T, p0)
  + A7.z0 e(Object, G1, T, p0)
  + A7.z0 o(boolean, G1, T, p0)
  + D5.e <init>(Throwable, boolean, t, b, P0, int)
  + D6.k e(I, String) → b
  + F.e A(J, m, p, int)
  + F.e l(f, t, b, p, int)
  + F.e m(t, p, int)
  + F.e n(g, t, b, p, int)
  + G.g V(f, k, String) → m
  + G.g d(t, p, int)
  + G.g e(u, P0, m, p, int)
  + G.g m(Throwable, boolean, t, b, P0, p, int)
  + G.g n(e, t, b, P0, p, int)
  + G.g p(boolean, String, List, a, m, float, c,
...✂

@tillh-stripe tillh-stripe force-pushed the tillh/instant-debits-billing-details branch 2 times, most recently from 7958cbe to 1d58dc0 Compare October 16, 2024 20:44
@tillh-stripe tillh-stripe force-pushed the tillh/instant-debits-billing-details branch 11 times, most recently from f8fb987 to 799f952 Compare October 18, 2024 16:54
@tillh-stripe tillh-stripe changed the base branch from master to tillh/bank-billing-details-collection October 18, 2024 16:54
@tillh-stripe tillh-stripe force-pushed the tillh/instant-debits-billing-details branch from 799f952 to e09b969 Compare October 18, 2024 19:20
@tillh-stripe tillh-stripe changed the base branch from tillh/bank-billing-details-collection to tillh/link-card-brand-and-billing-details October 18, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant