Improve multi-arch build + documentation #990
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rafaelgaspar
force-pushed
the
multiarch-improvements
branch
2 times, most recently
from
aaea764
to
1461507
Compare
|
This change LGTM, not sure why CircleCI is failing, I'm looking into that. Thanks! |
rafaelgaspar
force-pushed
the
multiarch-improvements
branch
from
3dc43c2
to
830ab81
Compare
|
Updated docs to include both single arch and multi-arch commands since most people building this locally would still prefer to just build for their current architecture. Let me know if the linting on CHANGELOG.md and README.md are a problem and I can revert them. |
rafaelgaspar
force-pushed
the
multiarch-improvements
branch
from
830ab81
to
e06d88c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to make #947 easier, this change makes use golang native cross-compilation making image building when build for both AMD64 and ARM64 around 5-6x faster.
Motivation
I'm also depending on issue #947 resolved, and I'm at your disposal for any help that I can provide.
Test plan
I'm still conducting internal testing of this.
Rollout/monitoring/revert plan
This should have no impact on AMD64 images, but ARM64 still requires more testing, but I don't think that should be a blocker on release.
The command used to build the images needs to be updated, but could not find it anywhere in code, so I'm assuming you are doing this manually on release, in that case please use the updated command in the
public-docker-images/README.mdfile but replacing--output=type=dockerwith--push.